feat: can compress image data before sending it to over the websocket #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #109 +/- ##
==========================================
- Coverage 50.00% 44.44% -5.56%
==========================================
Files 7 8 +1
Lines 140 189 +49
==========================================
+ Hits 70 84 +14
- Misses 70 105 +35 ☔ View full report in Codecov by Sentry. |
maartenbreddels
force-pushed
the
feat_compress_image_data
branch
6 times, most recently
from
d5b2eeb
to
148de2c
Compare
This is useful when the widget is being used over a non-local network. This can reduce the network traffic by a factor of 80 (for smooth, easy to compress images). Pure noise image (random pixels) will not compress well but will still see a factor of 7 reduction in size, due to using uint8 instead of float64.
maartenbreddels
force-pushed
the
feat_compress_image_data
branch
from
148de2c
to
fa48411
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful when the widget is being used over a non-local network. This can reduce the network traffic by a factor of 80 (for smooth, easy to compress images). Pure noise image (random pixels) will not compress well but will still see a factor of 7 reduction in size, due to using uint8 instead of float64.
Pull Request Template
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.